fix(keys): properly re-create buffer-local mappings. Fixes #1448

lua/lazy/core/handler/keys.lua

@@ -123,11 +123,6 @@ function M:_add(keys)
         Util.track()
       end
 
-      -- Create the real buffer-local mapping
-      if keys.ft then
-        self:_set(keys, buf)
-      end
-
       if keys.mode:sub(-1) == "a" then
         lhs = lhs .. "<C-]>"
       end
@@ -162,19 +157,21 @@ function M:_add(keys)
   end
 end
 
--- Delete a mapping and create the real global
+-- Delete a mapping and create the real global/buffer-local
 -- mapping when needed
 ---@param keys LazyKeys
 function M:_del(keys)
-  pcall(vim.keymap.del, keys.mode, keys.lhs, {
+  -- bufs will be all buffers of the filetype for a buffer-local mapping
-    -- NOTE: for buffer-local mappings, we only delete the mapping for the current buffer
+  -- OR `false` for a global mapping
-    -- So the mapping could still exist in other buffers
+  local bufs = keys.ft
-    buffer = keys.ft and true or nil,
+      and vim.tbl_filter(function(buf)
-  })
+        return vim.bo[buf].filetype == keys.ft
-  -- make sure to create global mappings when needed
+      end, vim.api.nvim_list_bufs())
-  -- buffer-local mappings are managed by lazy
+    or { false }
-  if not keys.ft then
+
-    self:_set(keys)
+  for _, buf in ipairs(bufs) do
+    pcall(vim.keymap.del, keys.mode, keys.lhs, { buffer = buf or nil })
+    self:_set(keys, buf or nil)
   end
 end